To: Laurent Pinchart +Cc: balbi, b-liu, nsekhar, linux-usb, linux-kernel
10:57 ` Felipe Balbi 1 sibling, 0 replies 8+ messages in thread 20:50 ` Laurent Pinchart 8:41 ` Roger Quadros > ioctl(dev->fd, UVCIOC_SEND_RESPONSE, &resp) > diff -git a/uvc-gadget.c b/uvc-gadget.c > 1 file changed, 2 insertions(+), 2 deletions(-) > On dwc3 gadget controller it was resulting in Buffer Expiry error on > Without this, the ISO streaming doesn't work if host application If you're fine with that I'll change the message when applying, there's no Thus not send the status response manually with UVCIOC_SEND_RESPONSE in any of
#Alternote widget driver#
In the second case, the driver sends the status response immediately. In the first case, the driver will issue aĭelayed status response automatically when we call the VIDIOC_STREAMON ioctl. On alternate setting change, the webcam gadget sends us a UVC_EVENT_STREAMON "uvc-gadget: Do not send Set Interface (alternate setting) response twice Wording the above two paragraphs as follows. The patch is correct changing both, but I propose In response to a STREAMON event, but not why we shouldn't either in response The commit message only explains why we should not call UVCIOC_SEND_RESPONSE > So we must not send UVCIOC_SEND_RESPONSE ioctl in these cases that too > It sends the delayed response when we issue the VIDIOC_STREAMON ioctl. > STREAMON event only but doesn't expect us to send that response over USB. > On alternate setting change, webcam gadget sends us a UVC_EVENT_STREAMON
To: Roger Quadros +Cc: balbi, b-liu, nsekhar, linux-usb, linux-kernel 10:57 ` Felipe Balbi 1 sibling, 2 replies 8+ messages in threadįrom: Laurent Pinchart 20:50 UTC ( / raw) 14:29 ` Felipe Balbi 20:50 ` Laurent Pinchart 11:17 uvc-gadget: Fix Set Interface (alternate setting) response behaviour Roger Quadros Patch v2 an hour ago, but the patch is still not on the mailing list 14:29 ` Felipe Balbi 14:39 ` Bin Liu 0 siblings, 0 replies 8+ messages in threadĬc: Roger Quadros, laurent.pinchart, nsekhar, linux-usb, linux-kernel 20:50 ` Laurent Pinchart 1 sibling, 1 reply 8+ messages in threadĬc: b-liu, nsekhar, linux-usb, linux-kernel, Roger Quadros 11:17 uvc-gadget: Fix Set Interface (alternate setting) response behaviour Roger 14:29 ` Felipe Balbi * Re: uvc-gadget: Fix Set Interface (alternate setting) response behaviour
20:50 ` Laurent Pinchart 0 siblings, 2 replies 8+ messages in threadįrom: Roger Quadros 11:17 UTC ( / raw)Ĭc: balbi, b-liu, nsekhar, linux-usb, linux-kernel, Roger Quadros
#Alternote widget archive#
Uvc-gadget: Fix Set Interface (alternate setting) response behaviour archive mirror help / color / mirror / Atom feed * uvc-gadget: Fix Set Interface (alternate setting) response behaviour 11:17 Roger Quadros
0 kommentar(er)
